Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative fix to the dir path bug problem. This seemingly fixes the issue on Windows 10, though I have not tested the modifications on Linux / OS X or other Windows versions.
In essence, what these changes should do, is that in the
new_command
function of the driver, it performs a check to see, whether the OS iswindows
. If this is the case, it applies a custom formatting command (format_cmd
), otherwise, it should proceed as before.New commands:
clear_format
: When parsed a string, it removes the singular.
from the front if it is there, otherwise, if it is..
or more dots, it should not remove these. Then, after this, it will attempt to remove all consecutive/
and\
reachable from the front and the back, which purpose is to eventually yield a string with some format where the leftmost part of the string is a folder name, and the rightmost part is also a folder name.format_cmd
: This cleans both the program's cmd path and user specified dir path withclear_format
, then, if dir is a non-zero string, appends cmd path to the dir path, making sure to place a/
between the two, which should be doable, since neither end or begin with a/
or\
. Likewise, it checks the dir path for a drive letter format, if not, then it appends./
as would otherwise be there.Hopefully this solves the problem, or at the very least, lets us move towards a more complete solution 🙂