fix the issue that cannot emit MergeCells and DataValidations together #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfwn
added a commit
to sfwn/erda
that referenced
this pull request
Oct 17, 2023
sfwn
added a commit
to erda-project/erda
that referenced
this pull request
Oct 18, 2023
* pkg excel: support set sheet dataValidation for droplist * polish cell style; add ut for mergeCells and dataValidations * use forked xlsx library to fix xlsx issue: tealeg/xlsx#785 * issue excel export sheet with sheetHandlers, for dataValidation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is very simple:
if
worksheet.MergeCellsis not nil andxw.Write(mergeCells)executed, code returned incorrectly.So, the logic of
worksheet.DataValidationswon't be executed even it's not nil.