Two new styles added for the table #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi @ErsinDagli, Thanks for this contribution. 😃 In order to maintain a high level of test coverage, we ask that all newly contributed code is accompanied by new tests. Would you mind adding tests for these new styles please? Thanks again, |
ghost
assigned
|
Hi @ErsinDagli How's it going? Any progress with these tests? They should be very easy to write - you'd just need to use the existing tests as a template. So please don't be put off! If you feel like it, there's also a new suggested style too. See #61 Tom |
|
I've added these tests and have merged these styles in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.