Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry, Summaries and TDigests #206

Open
pedrolamarao opened this issue Feb 7, 2023 · 5 comments
Open

OpenTelemetry, Summaries and TDigests #206

pedrolamarao opened this issue Feb 7, 2023 · 5 comments

Comments

@pedrolamarao
Copy link
Contributor

pedrolamarao commented Feb 7, 2023

I am raising this topic as a Github Issue for lack of a better place. If there is a more appropriate forum to raise such topics, please advise.

I have recently adopted OpenTelemetry as standard interface for integrating my components and telemetry infrastructure with great success, except for one point: computing quantiles with precision.

OpenTelemetry Metrics initial stable release offers instruments with type counter, gauge and histogram. It did at some point also offer type summary, which was all about quantiles, but those were removed before the first stable release. This act was captured in the merge request below. In my understanding of the issue, there were concerns over the "summability" of summaries.
open-telemetry/opentelemetry-proto#199

At the moment I read that discussion, and formed my understanding of the problem, immediately T-Digests came to mind. I opened a discussion topic at the OpenTelemetry Specification forum to point how appropriate T-Digests seem to solve the concerns raised for summary instruments.
open-telemetry/opentelemetry-specification#3118

Both T-Digest and OpenTelemetry have proven excellent components and I would love to see them working together!

@tdunning
Copy link
Owner

tdunning commented Feb 8, 2023 via email

@pedrolamarao
Copy link
Contributor Author

pedrolamarao commented Feb 8, 2023

Here is a link for the data model specification for OpenTelemetry Metrics:
https://opentelemetry.io/docs/reference/specification/metrics/data-model/

I am requesting guidance from the OpenTelemetry Java community on how to add new experimental instruments.

I am not familiar with T-Digest serialization format. Where can I learn more? It will be necessary to map this format onto JSON and Protobuf to fully support the OpenTelemetry Protocol -- which in turn allows bridging with the world via OpenTelemetry Collector.

@tdunning
Copy link
Owner

tdunning commented Feb 8, 2023 via email

@pedrolamarao
Copy link
Contributor Author

I'll fork the project once more and take a look at the code to see if I can get up to speed.
@tdunning could you please take a look at the discussion below on OpenTelemetry Java Github forum?
There was a question about serialization which I am not ready to answer.
open-telemetry/opentelemetry-java#5186

@tdunning
Copy link
Owner

tdunning commented Feb 10, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants