Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modern naming for IOS_DEPLOYMENT_TARGET #2405

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Modern naming for IOS_DEPLOYMENT_TARGET #2405

merged 1 commit into from
Apr 24, 2023

Conversation

Kylmakalle
Copy link
Contributor

@Kylmakalle Kylmakalle commented Apr 17, 2023 •
edited
Loading

This fixes setting the minimum deployable version for tvOS simulator. These changes also utilize modern naming for the min-version parameter. I was able to test it successfully using a customized build.sh

$ otool -l lib/libtdjson_static.a | grep -A3 -B1 "VERSION_MIN"
Load command 1
      cmd LC_VERSION_MIN_IPHONEOS
  cmdsize 16
  version 11.0
      sdk 16.2

Ref: rust-lang/rust#48862

@Kylmakalle
Modern naming for IOS_DEPLOYMENT_TARGET
6be04ab 
+ fix for tvos-simulator naming
@Kylmakalle Kylmakalle mentioned this pull request Apr 17, 2023
Open
@levlam levlam merged commit 0dc8ac5 into tdlib:master Apr 24, 2023
@Kylmakalle Kylmakalle deleted the patch-1 branch April 27, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kylmakalle @levlam