Skip to content

Conversation

@sinisa-colic
Copy link
Contributor

Using preference can create compatibility issues with original class because of changes made to constructor arguments made by Magento core team. Just in the last year they added 5 new arguments which can be seen here: AccountManagement model blame

@tdgroot
Copy link
Owner

tdgroot commented Jan 29, 2019

Hi @seeney97,

Thank you for your proposal! I was actually surprised that people are interested in this module.

I totally agree with you and your suggested changes make sense. There need to be done one extra change though.

Could you add a plugin for resetting a password as well? On a traditional Magento frontend, those are the two main points password validation kicks in.

Copy link
Owner

@tdgroot tdgroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a plugin for resetting a password as well!

@tdgroot
Copy link
Owner

tdgroot commented Jan 29, 2019

@seeney97 thanks for getting back to it so quickly! I will test the changes coming week and get it merged :).

@sinisa-colic
Copy link
Contributor Author

You are welcome 😄. I came up with idea to make exactly the same module, but after finding out it was already created i decided to improve it instead.

@tdgroot tdgroot merged commit 6d52d3e into tdgroot:master May 8, 2020
@tdgroot
Copy link
Owner

tdgroot commented May 8, 2020

@sinisa-colic sorry for getting back to this PR so late. I merged your changes, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants