Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bindings/js): unfix segfault #517

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

perrin4869
Copy link
Contributor

The os.Exit(0) call will terminate the node process completely and return a 0 status, making it seem like the test passed, but that will also prematurely terminate any running program...

@perrin4869 perrin4869 marked this pull request as draft July 10, 2022 18:37
@codecov-commenter
Copy link

Codecov Report

Merging #517 (1fbad93) into master (c7c19e3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   83.16%   83.16%           
=======================================
  Files          25       25           
  Lines        6678     6678           
=======================================
  Hits         5554     5554           
  Misses       1071     1071           
  Partials       53       53           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c19e3...1fbad93. Read the comment docs.

tdewolff added a commit that referenced this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants