Update overview.rst #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 0f69916...65adec2.
|
6 tasks
tdcmeehan
pushed a commit
that referenced
this pull request
Nov 6, 2025
…b#26529) Summary: 1. Fix an error of refresh MV after base table insertion 2. Use ExpressionUtil in MV refresh query composing 3. Fix an issue in MV caused by copying catalog properties during session creation For #3, we need a follow up to understand why the check of setting transaction id and catalog properties during session constructor is needed. I don't see a clear reason by checking the previous relavant commits. I'll check with some additional people. If no clear objection, I'll remove that check at least from the Session constructor in following PRs, and restoring the copy of catalog properties in buildOwnerSession(). Differential Revision: D86223888 ## Release Notes ``` == NO RELEASE NOTE == ```
tdcmeehan
pushed a commit
that referenced
this pull request
Feb 8, 2026
…ies and complex subqueries Issue #1 (cyclic join graphs): RPT's LargestRoot algorithm identifies back edges that create cycles. Materializing those joins as CTEs decomposes the cyclic graph into acyclic sections, each of which RPT can fully reduce independently. Issue #3 (complex subquery join inputs): Materializing aggregation/nested-join subqueries as CTEs converts them to TableScanNodes on temporary tables. RPT can then push BFs into these scans with column pruning. CteProjectionAndPredicatePushDown can further push TupleDomain ranges back into CTE producers. Both leverage existing CTE infrastructure: LogicalCteOptimizer, PhysicalCteOptimizer, SequenceNode, CTEMaterializationTracker. https://claude.ai/code/session_01SAXk4AS8yQyQkhRVi6RQie
tdcmeehan
pushed a commit
that referenced
this pull request
Feb 8, 2026
New issues: - #13: Cost model assumes local NVMe, invalid for S3/HDFS (0.3s becomes 5-30s) - prestodb#14: Parquet BF section is 115-line dead end, should be condensed - prestodb#15: Duplicate section numbering (two "Section 6" headers) - prestodb#16: Superlinear join efficiency claims lack citations - prestodb#17: CTE materialization cost missing from quantitative cost model - prestodb#18: Reduced hash table may still exceed VRAM — fallback composition unclear Updated existing issues: #1,#3 remaining gaps noted, #2 now worse (more occurrences), #7 partially addressed. 12 open issues total. https://claude.ai/code/session_01SAXk4AS8yQyQkhRVi6RQie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: