Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/calendar icon cursor #288

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Bug/calendar icon cursor #288

merged 3 commits into from
Jun 3, 2024

Conversation

Keyvan0111
Copy link
Collaborator

💎 Changes

Closes [#223]

Use a list to express the changes if there are multiple:

  • Made default cursor for Icons as pointer, but made it possible to pass type as parameter on demand
  • Added a name for each calendar icon next to the header. previous ones meant nothing
image

@Keyvan0111
Copy link
Collaborator Author

Even though it is fixed now, we need a better solution. Active and upcoming are kind of the same, but they never become green(eg. active)

@otytlandsvik
Copy link
Collaborator

active is not a property on events. Not sure what was the original idea here, but maybe we can use another attribute to display in this column? Binding registration, whether it is public or not or maybe a combination of those?

Copy link
Collaborator

@otytlandsvik otytlandsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice touch displaying what icon colors mean in this context.
Remember gitmojis and concise commit messages.

You can either:

  • Display icon color based on another property that makes sense, like discussed. In this case, push new changes to the same branch and request another review
  • Merge this branch now and create an issue on the icon color subject

@Keyvan0111 Keyvan0111 merged commit cee8e73 into master Jun 3, 2024
1 check passed
@Keyvan0111 Keyvan0111 deleted the bug/calendarIconCursor branch June 3, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants