Feature/tdbytes #96
Merged
Feature/tdbytes #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stiansolli
approved these changes
May 27, 2024
FredrikMorstad
approved these changes
May 27, 2024
app/api/kiosk.py
Outdated
Comment on lines
20
to
21
| if member is None: | ||
| raise HTTPException(500) |
There was a problem hiding this comment.
Maybe 404 here, not really an internal server error IMO
|
|
||
| class KioskSuggestion(KioskSuggestionPayload): | ||
| id: str | ||
| member: Member |
There was a problem hiding this comment.
Just a question, do we need to know the member adding a suggestion?
There was a problem hiding this comment.
Not a requirement, and only admins are allowed to view this data as it can be sensitive. However, I thought it was a nice utility if admins want to ask a person what they mean by certain suggestions, or hold users accountable for spamming or other abuse.
|
|
||
|
|
||
| @router.post("/suggestion") | ||
| def add_suggestion( |
There was a problem hiding this comment.
Maybe not relevant now, but we should maybe look to guard against users spamming suggestions
There was a problem hiding this comment.
Agreed, many endpoints could use some rate limiting mechanism
otytlandsvik
force-pushed
the
feature/tdbytes
branch
from
b3af291
to
8edad90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💎 tdBytes pages and kiosk admin role
Added endpoints for kiosk product suggestions
Also added a new kiosk admin role to allow non-admins to view suggestions
🐳 removed obsolete version tags from docker compose files