Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMR in docker-compose-dev #1818

Merged
merged 1 commit into from
Jun 27, 2024
Merged

HMR in docker-compose-dev #1818

merged 1 commit into from
Jun 27, 2024

Conversation

shaneikennedy
Copy link
Contributor

Much nicer for developing the frontend, two things that we lose with this however is

  1. Open in browser when the dev server is ready (I always thought this was gimick-y anyways 😅 ), this is necessary for it to work at all, otherwise the process exits because of this error
  2. Vite no longer clears the terminal when it reloads, this was just my opinion but because it's running in compose vite isn't just clearing it's own logs it's clearing all the logs from the other containers, which is super annoying

jonasvoelcker
jonasvoelcker reviewed Jun 7, 2024
View reviewed changes
client/vite.config.mjs Outdated
clearScreen: false,
port: 4000,
open: false,
proxy: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two spaces too much.

jonasvoelcker
jonasvoelcker approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@jonasvoelcker jonasvoelcker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me :)

@tchiotludo tchiotludo merged commit 0be719d into tchiotludo:dev Jun 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasvoelcker jonasvoelcker jonasvoelcker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaneikennedy @jonasvoelcker @tchiotludo