Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #178

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Update README.md #178

merged 1 commit into from
Sep 27, 2024

Conversation

maxbrito500
Copy link
Contributor

Adding detailed instructions for pom.xml

Adding detailed instructions for pom.xml
@maxbrito500
Copy link
Contributor Author

This patch is related to the conversation at #176

```xml
<properties>
<nostr-java.version>0.6.1-SNAPSHOT</nostr-java.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

property:
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
is already defined in nostr-java's pom.xml.

your project might have additional explicit dependency for it above and beyond what's required for nostr-java, but that is exclusive to your project and unnecessary here as part of general instruction.

</properties>
```

Add Jitpack to the repositories:
Copy link
Collaborator

@avlo avlo Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obtaining nostr-java library jars. Two options:

Option 1: For pre-compiled binaries, add Jitpack to pom.xml repositories:

<repositories>
    <repository>
        <id>jitpack.io</id>
        <url>https://jitpack.io</url>
    </repository>
</repositories>

Option 2: To build and install your own nostr-java binaries:

$ cd <your_git_home_dir>
$ git clone [email protected]:tcheeric/nostr-java.git
$ cd nostr-java
$ git checkout <relevant_branch>
$ mvn clean install

@tcheeric
Copy link
Owner

tcheeric commented Aug 27, 2024 via email

@tcheeric tcheeric changed the base branch from main to develop September 27, 2024 16:22
@tcheeric tcheeric merged commit b893f42 into tcheeric:develop Sep 27, 2024
@maxbrito500
Copy link
Contributor Author

This is still on the development branch, why not on the main one?

Right now it is kept invisible to new users since they just see the main branch by default with the old instructions.

@tcheeric
Copy link
Owner

tcheeric commented Sep 27, 2024 via email

@maxbrito500
Copy link
Contributor Author

Thank you, just puzzled why it didn't went directly. Please do continue the good work, this is without doubt the best java library for nostr.

@tcheeric
Copy link
Owner

tcheeric commented Sep 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants