-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #178
Update README.md #178
Conversation
Adding detailed instructions for pom.xml
This patch is related to the conversation at #176 |
```xml | ||
<properties> | ||
<nostr-java.version>0.6.1-SNAPSHOT</nostr-java.version> | ||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
property:
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
is already defined in nostr-java's pom.xml.
your project might have additional explicit dependency for it above and beyond what's required for nostr-java, but that is exclusive to your project and unnecessary here as part of general instruction.
</properties> | ||
``` | ||
|
||
Add Jitpack to the repositories: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obtaining nostr-java library jars. Two options:
Option 1: For pre-compiled binaries, add Jitpack to pom.xml repositories:
<repositories>
<repository>
<id>jitpack.io</id>
<url>https://jitpack.io</url>
</repository>
</repositories>
Option 2: To build and install your own nostr-java binaries:
$ cd <your_git_home_dir>
$ git clone [email protected]:tcheeric/nostr-java.git
$ cd nostr-java
$ git checkout <relevant_branch>
$ mvn clean install
Thank you
--
Sent with Tuta; enjoy secure & ad-free emails:
https://tuta.com
26 Aug 2024, 22:41 by ***@***.***:
…
This patch is related to the conversation at > #176 <#176>
—
Reply to this email directly, > view it on GitHub <#178 (comment)>> , or > unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQMG7DCVYGQRFGGNZBQ6NDZTOHIZAVCNFSM6AAAAABNEX22HOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJRGA2TEMRSHA>> .
You are receiving this because you are subscribed to this thread.> Message ID: > <tcheeric/nostr-java/pull/178/c2311052228> @> github> .> com>
|
This is still on the development branch, why not on the main one? Right now it is kept invisible to new users since they just see the main branch by default with the old instructions. |
It will be merged to main in the weekend.
…--
Sent with Tuta; enjoy secure & ad-free emails:
https://tuta.com
27 Sept 2024, 17:29 by ***@***.***:
This is still on the development branch, why not on the main one?
Right now it is kept invisible to new users since they just see the main branch by default with the old instructions.
—
Reply to this email directly, > view it on GitHub <#178 (comment)>> , or > unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQMG7EX53USX6YMWJK6BFTZYWBWVAVCNFSM6AAAAABNEX22HOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZZGY2TMMZVGM>> .
You are receiving this because you modified the open/close state.> Message ID: > <tcheeric/nostr-java/pull/178/c2379656353> @> github> .> com>
|
Thank you, just puzzled why it didn't went directly. Please do continue the good work, this is without doubt the best java library for nostr. |
It's just the process that I'm following
PRs ----> develop ----> main🤙🙏--
Sent with Tuta; enjoy secure & ad-free emails:
https://tuta.com
27 Sept 2024, 19:43 by ***@***.***:
…
Thank you, just puzzled why it didn't went directly. Please do continue the good work, this is without doubt the best java library for nostr.
—
Reply to this email directly, > view it on GitHub <#178 (comment)>> , or > unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQMG7G3ERA24LM2GRVHRTLZYWRNFAVCNFSM6AAAAABNEX22HOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZZHA2TSNZYGM>> .
You are receiving this because you modified the open/close state.> Message ID: > <tcheeric/nostr-java/pull/178/c2379859783> @> github> .> com>
|
Adding detailed instructions for pom.xml