Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OkHttp instead of java.net. #166

Merged
merged 2 commits into from
May 26, 2024
Merged

Conversation

kuiperanon
Copy link
Contributor

@kuiperanon kuiperanon commented May 25, 2024

RE: #161

        return this.scheme.replaceFirst("ws", "http") + "://" + this.host;

This part is a bit hacky, but it's required because OkHttp will only accept URIs that have the "http" or "https" schemes. It still works like this, seemingly.

…mporary code to others for help with debugging.
@kuiperanon
Copy link
Contributor Author

I have noticed that I get strange different results when running this on Android. I'll try to set up a minimal example to see if I reproduce the issue.

@tcheeric tcheeric merged commit 52da7b5 into tcheeric:develop May 26, 2024
@tcheeric
Copy link
Owner

I am getting a few test failures after merging into the develop branch. I think it conflicts with Nick's changes. I am sure not a big deal, but can you please look into it when you have a chance?
Thanks.

@kuiperanon
Copy link
Contributor Author

@tcheeric I'll look into it tomorrow for sure!

@avlo
Copy link
Collaborator

avlo commented May 27, 2024

awesome addition of Relay URI format validation- it caught that exact discrepancy in my unit test strings.

unit tests updated and now successfully passing once again, changes submitted in PR 168

@tcheeric
Copy link
Owner

tcheeric commented May 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants