Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase against element android 1.6.8 #998

Merged
merged 71 commits into from
Dec 18, 2023

Merge tag 'v1.6.8' into rebase/element-android-1.6.8

cd98953
Select commit
Loading
Failed to load commit list.
Merged

Rebase against element android 1.6.8 #998

Merge tag 'v1.6.8' into rebase/element-android-1.6.8
cd98953
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks skipped Dec 18, 2023 in 4s

You tagged this GitGuardian alert as a false positive

8 secrets were uncovered from the scan of 71 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #998: rebase/element-android-1.6.8 👉 develop
GitGuardian id Secret Commit Filename
7196668 Generic Password 979324d matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt View secret
7196668 Generic Password 77a5767 matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt View secret
7196668 Generic Password 552b143 matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt View secret
7196668 Generic Password 979324d matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt View secret
7196668 Generic Password 77a5767 matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt View secret
7196668 Generic Password 552b143 matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt View secret
7196668 Generic Password cd98953 matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt View secret
7196668 Generic Password cd98953 matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CryptoTestHelper.kt View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Revoke and rotate the secret.

  2. If possible, rewrite git history with git commit --amend and git push --force.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

View more details on GitGuardian