-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase/element android 1.4.32 #713
Conversation
Bumps dokka-gradle-plugin from 1.7.0 to 1.7.10. --- updated-dependencies: - dependency-name: org.jetbrains.dokka:dokka-gradle-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps io.gitlab.arturbosch.detekt from 1.20.0 to 1.21.0. --- updated-dependencies: - dependency-name: io.gitlab.arturbosch.detekt dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…be omitted. [ExplicitItLambdaParameter]
…itching-unit-tests # Conflicts: # vector/src/main/java/im/vector/app/features/home/room/list/RoomListViewModel.kt
Currently translated at 88.6% (2062 of 2327 strings) Translation: Element Android/Element Android App Translate-URL: https://translate.element.io/projects/element-android/element-app/vi/
…n-test Fixing flaky `CantVerifyTest`
`OnboardingViewModel` tests
Currently translated at 99.0% (2306 of 2327 strings) Translation: Element Android/Element Android App Translate-URL: https://translate.element.io/projects/element-android/element-app/ru/
Fixes crash when entering non ascii username during account creation
Try to fix issues and simplify flow.
…locked Fix lockscreen's 'device locked' crash on Android 12 and 12L devices
…d-element-app Translations update from Weblate
7bb09c9
to
f93b489
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question - approved
|
||
buildConfigField "im.vector.app.features.crypto.keysrequest.OutboundSessionKeySharingStrategy", "outboundSessionKeySharingStrategy", "im.vector.app.features.crypto.keysrequest.OutboundSessionKeySharingStrategy.WhenTyping" | ||
|
||
buildConfigField "Long", "VOICE_MESSAGE_DURATION_LIMIT_MS", "120_000L" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Florian14 do you know where these build config went?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is from Element, the BuildConfig fields are now defined in Config.kt
. here is the related PR
Conflicts: .github/workflows/build.yml .github/workflows/quality.yml .github/workflows/tests.yml vector-config/src/main/java/im/vector/app/config/Config.kt vector/build.gradle vector/src/main/java/im/vector/app/core/di/SingletonModule.kt vector/src/main/java/im/vector/app/features/home/HomeActivityViewModel.kt vector/src/main/java/im/vector/app/features/home/HomeDetailFragment.kt vector/src/main/java/im/vector/app/features/home/HomeDrawerFragment.kt vector/src/main/java/im/vector/app/features/home/room/detail/TimelineViewModel.kt vector/src/main/java/im/vector/app/features/navigation/DefaultNavigator.kt vector/src/main/java/im/vector/app/features/roomdirectory/createroom/CreateRoomViewModel.kt
…nfiguration of the test environment
cda5563
to
edf775d
Compare
Rebase against Element-Android v1.4.32 (changelog)