Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-674: Display shields at the end of verification #689

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

Claire1817
Copy link
Contributor

@github-actions
Copy link

Unit Test Results

149 tests  ±0   149 ✔️ ±0   23s ⏱️ +2s
  24 suites ±0       0 💤 ±0 
  24 files   ±0       0 ±0 

Results for commit 4479c5c. ± Comparison against base commit 45a5138.

Copy link
Contributor

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM
test the verification process : OK (the shield is now displayed)
I didn't test the QR code process

@Claire1817 Claire1817 merged commit 2888760 into develop Aug 2, 2022
@Claire1817 Claire1817 deleted the cgizard/ISSUE-674 branch August 2, 2022 12:47
Florian14 pushed a commit that referenced this pull request Aug 10, 2022
* main: (1873 commits)
  Changelog
  Update version to 2.4.0
  Fix bug: remove this room from forum list is not displayed (#692)
  ISSUE-674: Display shields at the end of verification (#689)
  Fix invitation button
  Fix content scanner and disable unified push
  Update .github/workflows/build.yml
  Update .github/workflows/build.yml
  Update .github/workflows/build.yml
  Fix FAQ url
  Use executeTransactionAwait (need realm refresh in this case)
  try to disable dependabot
  generating 1.4.27 changelog and updating version
  Fixing crash when sharing plain text, such as a url
  Fix crashes when opening Thread (#6463)
  Timeline: fix validation of timeline event changes
  Fix ConcurrentModificationException on BackgroundDetectionObserver
  Bump tchap version after hotfix release
  remove unused if
  Try to disable dependabot script
  ...
Florian14 pushed a commit that referenced this pull request Aug 11, 2022
* main: (1873 commits)
  Changelog
  Update version to 2.4.0
  Fix bug: remove this room from forum list is not displayed (#692)
  ISSUE-674: Display shields at the end of verification (#689)
  Fix invitation button
  Fix content scanner and disable unified push
  Update .github/workflows/build.yml
  Update .github/workflows/build.yml
  Update .github/workflows/build.yml
  Fix FAQ url
  Use executeTransactionAwait (need realm refresh in this case)
  try to disable dependabot
  generating 1.4.27 changelog and updating version
  Fixing crash when sharing plain text, such as a url
  Fix crashes when opening Thread (#6463)
  Timeline: fix validation of timeline event changes
  Fix ConcurrentModificationException on BackgroundDetectionObserver
  Bump tchap version after hotfix release
  remove unused if
  Try to disable dependabot script
  ...
Florian14 pushed a commit that referenced this pull request Aug 11, 2022
* main: (1873 commits)
  Changelog
  Update version to 2.4.0
  Fix bug: remove this room from forum list is not displayed (#692)
  ISSUE-674: Display shields at the end of verification (#689)
  Fix invitation button
  Fix content scanner and disable unified push
  Update .github/workflows/build.yml
  Update .github/workflows/build.yml
  Update .github/workflows/build.yml
  Fix FAQ url
  Use executeTransactionAwait (need realm refresh in this case)
  try to disable dependabot
  generating 1.4.27 changelog and updating version
  Fixing crash when sharing plain text, such as a url
  Fix crashes when opening Thread (#6463)
  Timeline: fix validation of timeline event changes
  Fix ConcurrentModificationException on BackgroundDetectionObserver
  Bump tchap version after hotfix release
  remove unused if
  Try to disable dependabot script
  ...
Florian14 pushed a commit that referenced this pull request Aug 11, 2022
* main: (1873 commits)
  Changelog
  Update version to 2.4.0
  Fix bug: remove this room from forum list is not displayed (#692)
  ISSUE-674: Display shields at the end of verification (#689)
  Fix invitation button
  Fix content scanner and disable unified push
  Update .github/workflows/build.yml
  Update .github/workflows/build.yml
  Update .github/workflows/build.yml
  Fix FAQ url
  Use executeTransactionAwait (need realm refresh in this case)
  try to disable dependabot
  generating 1.4.27 changelog and updating version
  Fixing crash when sharing plain text, such as a url
  Fix crashes when opening Thread (#6463)
  Timeline: fix validation of timeline event changes
  Fix ConcurrentModificationException on BackgroundDetectionObserver
  Bump tchap version after hotfix release
  remove unused if
  Try to disable dependabot script
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants