-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-674: Display shields at the end of verification #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giomfo
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
test the verification process : OK (the shield is now displayed)
I didn't test the QR code process
Florian14
pushed a commit
that referenced
this pull request
Aug 10, 2022
* main: (1873 commits) Changelog Update version to 2.4.0 Fix bug: remove this room from forum list is not displayed (#692) ISSUE-674: Display shields at the end of verification (#689) Fix invitation button Fix content scanner and disable unified push Update .github/workflows/build.yml Update .github/workflows/build.yml Update .github/workflows/build.yml Fix FAQ url Use executeTransactionAwait (need realm refresh in this case) try to disable dependabot generating 1.4.27 changelog and updating version Fixing crash when sharing plain text, such as a url Fix crashes when opening Thread (#6463) Timeline: fix validation of timeline event changes Fix ConcurrentModificationException on BackgroundDetectionObserver Bump tchap version after hotfix release remove unused if Try to disable dependabot script ...
Florian14
pushed a commit
that referenced
this pull request
Aug 11, 2022
* main: (1873 commits) Changelog Update version to 2.4.0 Fix bug: remove this room from forum list is not displayed (#692) ISSUE-674: Display shields at the end of verification (#689) Fix invitation button Fix content scanner and disable unified push Update .github/workflows/build.yml Update .github/workflows/build.yml Update .github/workflows/build.yml Fix FAQ url Use executeTransactionAwait (need realm refresh in this case) try to disable dependabot generating 1.4.27 changelog and updating version Fixing crash when sharing plain text, such as a url Fix crashes when opening Thread (#6463) Timeline: fix validation of timeline event changes Fix ConcurrentModificationException on BackgroundDetectionObserver Bump tchap version after hotfix release remove unused if Try to disable dependabot script ...
Florian14
pushed a commit
that referenced
this pull request
Aug 11, 2022
* main: (1873 commits) Changelog Update version to 2.4.0 Fix bug: remove this room from forum list is not displayed (#692) ISSUE-674: Display shields at the end of verification (#689) Fix invitation button Fix content scanner and disable unified push Update .github/workflows/build.yml Update .github/workflows/build.yml Update .github/workflows/build.yml Fix FAQ url Use executeTransactionAwait (need realm refresh in this case) try to disable dependabot generating 1.4.27 changelog and updating version Fixing crash when sharing plain text, such as a url Fix crashes when opening Thread (#6463) Timeline: fix validation of timeline event changes Fix ConcurrentModificationException on BackgroundDetectionObserver Bump tchap version after hotfix release remove unused if Try to disable dependabot script ...
Florian14
pushed a commit
that referenced
this pull request
Aug 11, 2022
* main: (1873 commits) Changelog Update version to 2.4.0 Fix bug: remove this room from forum list is not displayed (#692) ISSUE-674: Display shields at the end of verification (#689) Fix invitation button Fix content scanner and disable unified push Update .github/workflows/build.yml Update .github/workflows/build.yml Update .github/workflows/build.yml Fix FAQ url Use executeTransactionAwait (need realm refresh in this case) try to disable dependabot generating 1.4.27 changelog and updating version Fixing crash when sharing plain text, such as a url Fix crashes when opening Thread (#6463) Timeline: fix validation of timeline event changes Fix ConcurrentModificationException on BackgroundDetectionObserver Bump tchap version after hotfix release remove unused if Try to disable dependabot script ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#674