Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room list is automatically scrolled to the top after opening a room #482

Merged
merged 4 commits into from
Mar 16, 2022

Conversation

Claire1817
Copy link
Contributor

@Claire1817 Claire1817 commented Mar 10, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

#481
We don't scroll to the position 0 when a room is opened/created

Motivation and context

Screenshots / GIFs

Enregistrement.de.l.ecran.2022-03-10.a.10.42.26.mov

Tests

  • Open a room, no scroll before the opening.
  • Create a room, no scroll before the opening

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@github-actions
Copy link

github-actions bot commented Mar 10, 2022

Unit Test Results

  15 files  ±0    15 suites  ±0   9s ⏱️ -1s
104 tests ±0  104 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 7b9e20a. ± Comparison against base commit 12dd29c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed=
  • [org.matrix.android.sdk.account]
    passed=
  • [org.matrix.android.sdk.internal]
    passed=
  • [org.matrix.android.sdk.ordering]
    passed=
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed=

@Florian14
Copy link
Contributor

The result is not ideal. There is no more scroll before opening the room, this is better but the scroll up still occur after coming back in the room list. This is probably normal as we reset the filter but we can probably prevent the reset if the filter is already empty, what do you think?

@giomfo giomfo added the android label Mar 14, 2022
@Florian14 Florian14 self-requested a review March 15, 2022 09:00
Copy link
Contributor

@Florian14 Florian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@Claire1817 Claire1817 merged commit 072bd30 into develop Mar 16, 2022
@Claire1817 Claire1817 deleted the cgizard/ISSUE-481 branch March 16, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants