[Login] Handle correctly M_LIMIT_EXCEEDED error code

[Claire1817]

#322

[github-actions]

Unit Test Results

11 files  ±0  11 suites  ±0   7s ⏱️ -2s
83 tests ±0  83 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c10a379. ± Comparison against base commit 0b5fb6f.

♻️ This comment has been updated with latest results.

[giomfo]

I disagree about this change.
If I understood correctly, you commented this block about exception.error.code == MatrixError.M_LIMIT_EXCEEDED, in order to prevent the application to be blocked until the end of the delay provided by the exception (which is 30 mins in our case). If this is true, this means canRetry and/or exception.shouldBeRetried() was false, which let you trigger the exception.

I think there is a bug in Element-android sdk here, we should check exception.shouldBeRetried() and canRetry booleans even when exception.error.code == MatrixError.M_LIMIT_EXCEEDED

About my suggestion:

• we have to check whether the login request is triggered by disabling the retry option
• we have to test the other cases where M_LIMIT_EXCEEDED error may be received to be sure we don't disturb them. For example when you send several messages in a room in a very short delay, you will trigger this error. I think this request (send message) enables the retry

[bmarty]

For more context the new retry policy regarding 429 has been added element-hq/element-android#3142.

[bmarty]

And in case of 429, the SDK automatically retry, whatever the value of canRetry

[giomfo]

@ClaireGizard After reviewing your PR, I don't think we are going in the right direction to fix this issue.
I assigned @Florian14 to consider again this issue with my point of view. I let you sync with him before considering my comment