Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The shield don't appear when sync with QR Code with Tchap Web V4 #674

Closed
jdauphant opened this issue Jul 11, 2022 · 4 comments
Closed

The shield don't appear when sync with QR Code with Tchap Web V4 #674

jdauphant opened this issue Jul 11, 2022 · 4 comments
Assignees
Labels
android bug Something isn't working

Comments

@jdauphant
Copy link
Contributor

jdauphant commented Jul 11, 2022

Step

  • Connect new device on Tchap Web V4
  • Click on verify on a connected Tchap Android
  • Scan the Tchap Web v4 QR code with android

No shield is showned on Android (but the Tchap Web v4 ask if a shield is showned)

image

@Claire1817 Claire1817 self-assigned this Jul 25, 2022
@Claire1817 Claire1817 added the bug Something isn't working label Jul 25, 2022
@Claire1817
Copy link
Contributor

Problem comes from: #296

@giomfo
Copy link
Contributor

giomfo commented Jul 25, 2022

@Claire1817 don't you think we may show the shield again (I think we restore the shield in some other places, like sessions list, so it may be visible at the end of the verification)

@Claire1817
Copy link
Contributor

This verification by QrCode is only available with the cross-signing.
@jdauphant you had the possibility to do this verification because Tchap web v4 didn't disable the cross-signing.

@giomfo yes, i think it's a good idea to display all the shields with the cross-signing enabling.

@giomfo
Copy link
Contributor

giomfo commented Jul 29, 2022

The plan is to restore the shield in 2 cases:

  • during the QR code verification flow
  • at the end of the verification

@giomfo giomfo closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants