In response to issue #325, rework the dependency allow-list. #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generally, the changes here allow a single dependency in the allow-list to have or **or more** versions specified, either as exact (`=`) or bounded ranges (`>=,<=`) or wildcards (`*`). PL/Rust will pick the largest (newest, hopefully) entry from the allow-list that matches the version the user's requested dependency version. Depending on how either is written, the allow-list version could be used or the user's requested version could be used. See the new documentation for more details.
thomcc
reviewed
Jun 12, 2023
No. I think it's just some spaghetti code. We discussed this in discord, specifically the |
thomcc
approved these changes
Jun 12, 2023
| fn validate_versionreq(vreq: &VersionReq, require_exact: bool) -> bool { | ||
| let has_prelrease = vreq.comparators.iter().any(|cmp| !cmp.pre.is_empty()); | ||
| if has_prelrease { | ||
| // -shitshow versions not allowed (https://docs.rs/semver/latest/semver/struct.Prerelease.html#examples) |
Merged
|
This change was really helpful by also allowing git dependencies -- thanks! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally, the changes here allow a single dependency in the allow-list to have one or more versions specified, either as exact (
=) or bounded ranges (>=,<=) or wildcards (*).PL/Rust will pick the largest (newest, hopefully) entry from the allow-list that matches the function's requested version. Depending on how either is written, the allow-list version could be used or the requested version could be used.
See the new documentation for more details.
As a drive-by, a number of our unit tests were tagged with
#[should_panic]but without an expected message. Turns out many of them were panicking but for the wrong reason! This PR addresses these too.That said, the
plrust_pgloglevel_dont_allcaps_panictest is currently set to#[ignore]. Its intent is to block using Postgres'PANIClog level (which purposely crashes the backend), and I'm not yet clear on how this is supposed to be addressed.