Don't require a loaded function to have "compile lints" applied. #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading an existing, compiled function should not require that it was previously compiled with the set of lints PL/Rust now uses for compilation. This prohibits newer versions of PL/Rust, which might have a new lint, from executing functions created with an older version without that lint. We do, however, continue to require the lints that are set in both the `$PLRUST_REQUIRED_LINTS` envar and the `plrust.required_lints` postgresql.conf GUC. This is a way for the administrator to flat out **require** that certain lints be applied to **every** function before it can be loaded/executed. PL/Rust's default stance, however, is that if it was good before, it's good now, even if new lints are applied going forward.
BradyBonnette
approved these changes
Jun 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading an existing, compiled function should not require that it was previously compiled with the set of lints PL/Rust now uses for compilation. This prohibits newer versions of PL/Rust, which might have a new lint, from executing functions created with an older version without that lint.
We do, however, continue to require the lints that are set in both the
$PLRUST_REQUIRED_LINTSenvar and theplrust.required_lintspostgresql.conf GUC. This is a way for the administrator to flat out require certain lints be applied to every function before it can be loaded/executed.PL/Rust's default stance, however, is that if it was good before, it's good now, even if new lints are applied going forward.