Remove simple_sequence #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added very early in the life of Flux with the intention of making it easy to write Flow-style (or Rust-style) iterators with just a `next() -> optional` method. It works fine, but it's not particularly useful -- if you're doing a quick prototype then `flux::generator` is quicker and easier, and otherwise a "full" sequence implementation isn't much more work and usually gets you multipass for free. So given that it's not useful and it's not used anywhere, let's get rid of it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 70 70
Lines 2471 2471
=======================================
Hits 2429 2429
Misses 42 42 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added very early in the life of Flux with the intention of making it easy to write Flow-style (or Rust-style) iterators with just a
next() -> optionalmethod.It works fine, but it's not particularly useful -- if you're doing a quick prototype then
flux::generatoris quicker and easier, and otherwise a "full" sequence implementation isn't much more work and usually gets you multipass for free.So given that it's not useful and it's not used anywhere, let's get rid of it.