More modules tinkering #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tcbrindle
commented
Aug 1, 2023
•
tcbrindle
commented
- Inline some non-template member functions
- Ensure the module can be built/imported in Windows CI runs
When using modules, non-template constructors and member functions defined in-class are not "inline"by default. This is generally a good thing, but in our particular case we have a few one-line forwarding functions that we would actually like to make available for inlining.
Let's see if this works...
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 66 66
Lines 2236 2236
=======================================
Hits 2184 2184
Misses 52 52
☔ View full report in Codecov by Sentry. |
tcbrindle
force-pushed
the
pr/modules_experiment
branch
from
8bd0d1c
to
e751375
Compare
|
Alas, trying to build the module in Clang/MacOS CI runs into difficulties. I'll try again another time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.