Add experimental CMake module support #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If CMake is configured with FLUX_BUILD_MODULE=On (default is Off), then we'll attempt to build a module using add_module_library() defined in modules.cmake. We'll also attempt to build a small test program to verify that the module can be correctly imported. Everything seems to work fine with Clang 16. With GCC 13, the Ninja generator currently runs into problems* building the module. With a Makefile generator, building the module succeeds, but the import fails complaining it can't find the generated module. I don't know if this is caused by a GCC bug or by modules.cmake. MSVC is not yet tested. * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105467
MSVC doesn't like the way we're #include-ing flux.hpp within the module purview, although it seems to work correctly, so we'll silence the warning.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 66 66
Lines 2236 2236
=======================================
Hits 2184 2184
Misses 52 52 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If CMake is configured with
FLUX_BUILD_MODULE=On(default is Off), then we'll attempt to build a module usingadd_module_library()from Victor Zverovich's modules.cmake.We'll also attempt to build a small test program to verify that the module can be correctly imported.
Everything seems to work fine with Clang 16. MSVC generates the module and test program correctly, but seems to have trouble with
flux::ref(), which rather rules out doing anything practical with modules right now.With GCC 13, the Ninja generator currently runs into problems* building the module. With a Makefile generator, building the module succeeds, but the import fails complaining it can't find the generated module. I don't know if this is caused by a GCC bug or by modules.cmake.