Initial, experimental modules support #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to work...
...and give it a .cpp extension as Clang and GCC prefer it
This is defined only when FLUX_MODULE_INTERFACE is defined, which is only the case when we're inside the module interface file
Previously, we were #include-ing flux.hpp in the global module fragment, and then exporting certain specific names within that. With this change, we're now putting the whole Flux lib in the module purview, and exporting certain names within that. If I understand correctly (and that's a big "if"!) this means that all the symbols in the library now have module linkage, which seems like what we want? It also means that we no longer need to maintain a separate list of exported entities, but instead should use the FLUX_EXPORT macro on their definition. We do now have to pre-include all the standard library headers instead to avoid "taking ownership" of the names therein, but this seems manageable.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 66 66
Lines 2236 2236
=======================================
Hits 2184 2184
Misses 52 52
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLUX_EXPORTwhich expands toexportiffFLUX_MODULE_INTERFACEis definedFLUX_EXPORTto all the names we want to exportmodule/subdir, which#includes all of our stdlib uses into the global module fragment, then does#include <flux.hpp>in the module purview, having first definedFLUX_MODULE_INTERFACE.This seems to work in initial testing with Clang 16 and GCC 13 using command line incantations. Not tested with MSVC yet.
No CMake support yet either, I might leave that for another time.