Correct test/built-ins/Function/prototype/bind/15.3.4.5-15-5.js #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `length` property should be [[Configurable]] https://tc39.github.io/ecma262/#sec-function.prototype.bind Also the test was testing deleting the wrong property. Fixes tc39#957.
leobalter
approved these changes
Apr 10, 2017
| ---*/ | ||
|
|
||
| var canConfigurable = false; | ||
| var hasProperty = false; | ||
| function foo() { } | ||
| var obj = foo.bind({}); | ||
| hasProperty = obj.hasOwnProperty("length"); | ||
| delete obj.caller; | ||
| delete obj.length; |
There was a problem hiding this comment.
omg, why were we deleting obj.caller here?
Thanks for finding this false positive.
This is also a reminder to convert these legacy tests to use the property helpers.
Btw, a reference for the length descriptor from the specs
8. Perform ! DefinePropertyOrThrow(F, "length", PropertyDescriptor {[[Value]]: L, [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: true}).
|
@JosephPecoraro can you sign the CLA, please? https://tc39.github.io/test262-cla/ If you already work for a org w/ a membership to ECMA, this is not necessary. Just confirm and I'll be able to merge this. |
|
I had signed the agreement in the past for (#761). You can clean it up and land. |
leobalter
approved these changes
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lengthproperty should be [[Configurable]]https://tc39.github.io/ecma262/#sec-function.prototype.bind
Also the test was testing deleting the wrong property.
Fixes #957.