Repository navigation
add tests for TA.prototype.with/filter shrinking/detaching buffer during coercion - #5136
Merged
Merged
Conversation
|
9 new or modified tests were run on 7 engines.
|
Member
Author
|
Huh, surprised by the jsc failures; it works on my machine. |
gibson042
approved these changes
Sep 17, 2026
linusg
requested changes
Sep 18, 2026
gibson042
reviewed
Sep 18, 2026
linusg
approved these changes
Sep 18, 2026
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Ms2ger
force-pushed
the
ta-coercion-errors
branch
from
September 21, 2026 08:09
496eda4 to
9925316
Compare
Ms2ger
enabled auto-merge (squash)
September 21, 2026 08:10
lahma
added a commit
to sebastienros/jint
that referenced
this pull request
Sep 24, 2026
…rinking coercion (#4157) Moves SuiteGitSha 35d56660 -> 7ab7fafa (5 upstream commits, test-only, no features.txt change) and recomputes CorpusContentSha256 over the new tree. %TypedArray%.prototype.with bulk-copied the length it read before coercing the index and the value, so a coercion that shrank a resizable buffer made Array.Copy read past the reallocated block and a CLR ArgumentException escaped into the host. It now copies only the elements the source still has and writes undefined through TypedArraySetElement for the rest (NaN, +0, or a TypeError for BigInt), per tc39/ecma262#3979 as tested by tc39/test262#5136. intl402/DateTimeFormat/prototype/format/german-weekday-no-year.js parks under the INTL402 banner: it needs CLDR availableFormats skeleton matching and format-context weekday names, which the component-bag lane lacks. Claude-Session: https://claude.ai/code/session_01PanPJbBD7pQC9fRiTpHxvs Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For tc39/ecma262#3979. Written by an LLM based off that PR.
These pass in the engines I have on hand except that some of them fail in Boa, which asserts as the spec currently (and incorrectly) does.
Also added the test/built-ins/TypedArray/prototype/with/BigInt/negative-index-resize-to-out-of-bounds.js because my version of Node throws the wrong error in that case for some reason (but v8 gets it right).