Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rab/gsab] Return false in [[PreventExtensions]] for variable-length TAs #4325

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

test262-pr-bot
Copy link

This is a spec normative change: tc39/ecma262#3453

Fixed: 374310073
Change-Id: I085260fea077bc27cf1e4f06d4389519e12c4e14
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6014979
Commit-Queue: Shu-yu Guo <[email protected]>
Auto-Submit: Shu-yu Guo <[email protected]>
Commit-Queue: Rezvan Mahdavi Hezaveh <[email protected]>
Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#97166}

This is a spec normative change: tc39/ecma262#3453

Fixed: 374310073
Change-Id: I085260fea077bc27cf1e4f06d4389519e12c4e14
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6014979
Commit-Queue: Shu-yu Guo <[email protected]>
Auto-Submit: Shu-yu Guo <[email protected]>
Commit-Queue: Rezvan Mahdavi Hezaveh <[email protected]>
Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#97166}
@ljharb
Copy link
Member

ljharb commented Nov 13, 2024

is this a duplicate of #4324?

@syg
Copy link
Contributor

syg commented Nov 13, 2024

is this a duplicate of #4324?

No, this PR adds tests for seal and preventExtensions. #4324 updates existing freeze tests.

Copy link
Contributor

@test262-merge-bot test262-merge-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the V8 project.

@test262-merge-bot test262-merge-bot merged commit 05c45a4 into main Nov 13, 2024
15 checks passed
@test262-merge-bot test262-merge-bot deleted the chromium-export-4ff7b07089 branch November 13, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants