Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the not-a-constructor test for Math.f16round() #4323

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Fix the not-a-constructor test for Math.f16round() #4323

merged 1 commit into from
Nov 12, 2024

Conversation

rmg-x
Copy link
Contributor

@rmg-x rmg-x commented Nov 12, 2024 •
edited
Loading

Previously, this was using Math.fround() instead of the f16 version.

Found while reviewing #4017

@rmg-x
Fix the not-a-constructor test for Math.f16round()
fd9c35e 
Previously, this was using Math.fround() instead of the f16 version.
@rmg-x rmg-x requested a review from a team as a code owner November 12, 2024 13:13
Ms2ger
Ms2ger approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ms2ger Ms2ger merged commit 8eee455 into tc39:main Nov 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmg-x @Ms2ger