Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DurationFormat: Add tests for durations with large hour/minute/second unit values while using digital style #4268

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

ben-allen
Copy link
Contributor

Grouping separators suppressed in this situation. See tc39/proposal-intl-duration-format/pull/198

fix #4190

@ben-allen ben-allen marked this pull request as ready for review October 15, 2024 20:56
@ben-allen ben-allen requested a review from a team as a code owner October 15, 2024 20:56
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

… unit values while using digital style

Grouping separators suppressed in this situation. See tc39/proposal-intl-duration-format/pull/198
@ptomato ptomato force-pushed the style-digital-grouping-separators branch from 5cc3e0f to 4bd8562 Compare October 30, 2024 23:01
@ptomato ptomato merged commit febf246 into tc39:main Oct 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need test for intl-duration-format/pull/198
2 participants