Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate staging tests for JSON-parse-with-source #4265

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Migrate staging tests for JSON-parse-with-source #4265

merged 2 commits into from
Nov 6, 2024

Conversation

ioannad
Copy link
Contributor

@ioannad ioannad commented Oct 15, 2024 •
edited
Loading

Partially addresses testing plan issue #4096

@ioannad ioannad requested review from a team as code owners October 15, 2024 16:42
@ptomato ptomato force-pushed the migrate-staging-JSON-parse-with-source branch from 3e3e685 to 300154f Compare October 31, 2024 18:59
ptomato
ptomato requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

test/built-ins/JSON/isRawJSON/invoked-as-a-fn.js Outdated Show resolved Hide resolved
test/built-ins/JSON/isRawJSON/invoked-as-a-fn.js Outdated Show resolved Hide resolved
test/built-ins/JSON/isRawJSON/invoked-as-a-fn.js Outdated Show resolved Hide resolved
test/built-ins/JSON/rawJSON/invoked-as-a-fn-BigInt.js Outdated Show resolved Hide resolved
test/built-ins/JSON/rawJSON/invoked-as-a-fn-BigInt.js Outdated Show resolved Hide resolved
test/built-ins/JSON/rawJSON/invoked-as-a-fn.js Outdated Show resolved Hide resolved
test/built-ins/JSON/parse/test-InternaliseJSONProperty.js Outdated Show resolved Hide resolved
test/built-ins/JSON/parse/test-InternaliseJSONProperty.js Outdated Show resolved Hide resolved
test/built-ins/JSON/parse/test-CreateJSONParseRecord.js Outdated Show resolved Hide resolved
test/built-ins/JSON/parse/test-CreateJSONParseRecord.js Outdated Show resolved Hide resolved
@ptomato ptomato force-pushed the migrate-staging-JSON-parse-with-source branch 2 times, most recently from 45c007e to 48e36cc Compare November 1, 2024 19:45
ptomato
ptomato approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ioanna isn't available in the short term to work further on this, so I went ahead and made the modifications that I requested. Anyone else feel like giving it another look?

@Ms2ger Ms2ger force-pushed the migrate-staging-JSON-parse-with-source branch from 74d2aeb to 024de11 Compare November 6, 2024 15:56
@Ms2ger Ms2ger enabled auto-merge (squash) November 6, 2024 15:57
@Ms2ger Ms2ger merged commit 437f9a7 into tc39:main Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato approved these changes

@Ms2ger Ms2ger Ms2ger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ioannad @Ms2ger @ptomato