Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boilerplate tests for rawJSON and isRawJSON #4255

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Boilerplate tests for rawJSON and isRawJSON #4255

merged 6 commits into from
Oct 15, 2024

Conversation

ioannad
Copy link
Contributor

@ioannad ioannad commented Oct 9, 2024

from the proposal json-parse-with-source.

Partially addresses testing plan issue #4096

@ioannad
Boilerplate tests for rawJSON and isRawJSON
dc4e924 
from the proposal json-parse-with-source
@ioannad ioannad requested a review from a team as a code owner October 9, 2024 19:24
ptomato
ptomato approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great, but I'd either update or delete the frontmatter in the length and name tests so that it points to the relevant section.

test/built-ins/JSON/isRawJSON/name.js Outdated Show resolved Hide resolved
test/built-ins/JSON/isRawJSON/length.js Outdated Show resolved Hide resolved
test/built-ins/JSON/isRawJSON/name.js Outdated Show resolved Hide resolved
test/built-ins/JSON/rawJSON/length.js Outdated Show resolved Hide resolved
test/built-ins/JSON/rawJSON/name.js Outdated Show resolved Hide resolved
test/built-ins/JSON/rawJSON/name.js Outdated Show resolved Hide resolved
ptomato
ptomato approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ptomato ptomato merged commit 3cacf7d into tc39:main Oct 15, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ioannad @ljharb @ptomato