Run full test suite for non-PR builds #4183
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing to run full suite of tests when running against
main
branch. This will give full listing of currently unsupported tests by engine. Also updating to latest NPM dependencies.Test will still be green on CI like for PRs when errors are present, see 1ebd34b for original reasoning not erroring.
I would argue that it would be better if the PRs would fail and maintainers would need to read the actual error output to figure out whether problems are correct. The test262-harness has a flag for this
--error-for-failures
which would break PR builds if there's a problem. Of course this would create noise for unsupported features per engine.