-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decorators tests #4103
base: main
Are you sure you want to change the base?
Add decorators tests #4103
Conversation
I've completed writing the tests, now I just need to actually get them to run properly and debug any issues (could be typos, etc). |
https://github.com/babel/babel-test262-runner/ could be useful to run the tests and check if they have any problem. |
Yes, I've been using that repo for testing in general. The previous commit for fields (a3b4282) was passing, at that point I kinda had all the details figured out for the overall structure so I scaffolded out all of the tests themselves and made sure I had written all of the ones we needed. Next is just running them again to see if they work and fixing issues. I'm sure there are minor issues, definitely, but could also be some larger ones. @nicolo-ribaudo one quick question, the generators in |
f72b125
to
aa99427
Compare
This PR is now ready for review. There are some tests that are failing against the Babel test runner that I can't figure out:
I believe that's it though. The tests should cover the bulk of decorator behavior, there may be some small gaps but we can address those in followups, this is already a massive PR and I don't want to continue adding to it. |
@pzuraq We discussed this in yesterday's test262 meeting. We plan to start reviewing it after tackling one other large PR that's been waiting longer. In the meantime, would you mind splitting the commit on this branch into two commits, one with any hand-written changes and one with autogenerated changes? We'll focus on the former. |
Ok, sounds good! I can get that done likely by the end of the month or early next month. |
aa99427
to
15f73b9
Compare
@pzuraq I went ahead and investigated which tests were autogenerated — it looks like they all are! 😄 A few of them don't have corresponding templates in
|
This PR is still a WIP, I will be trying to wrap it up tomorrow. Took me a while to get best way to combine templates and cases to have as wide coverage as possible without having to write out every permutation manually.