Fix groupBy string test keys to be insertion order #4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was added in #4038; ping @sosukesuzuki |
ljharb
approved these changes
Apr 11, 2024
ljharb
added a commit
to es-shims/Object.groupBy
that referenced
this pull request
Apr 11, 2024
ljharb
added a commit
to es-shims/Map.groupBy
that referenced
this pull request
Apr 11, 2024
ctcpip
approved these changes
Apr 11, 2024
The CI runs PRs against implementations, but only confirms that the tests can be run from beginning to end, not that they pass. (Only the ESMeta job checks if they pass.) |
ptomato
approved these changes
Apr 11, 2024
ptomato
force-pushed
the
fix-groupby-order
branch
from
7eddf30
to
3672f5d
Compare
|
Ahh sorry, thank you. |
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Apr 22, 2024
See tc39/test262#4053 Bug: v8:12499 Change-Id: Ib60ed75dbd92ae1e052d76d56445c0fbad2796a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5472808 Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]> Commit-Queue: Rezvan Mahdavi Hezaveh <[email protected]> Auto-Submit: Shu-yu Guo <[email protected]> Commit-Queue: Shu-yu Guo <[email protected]> Cr-Commit-Position: refs/heads/main@{#93510}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥰, the first emoji, has the key
'after', so the insertion order of the keys is'after', 'before'.Also, this test was committed after multiple engines have shipped
groupBy. Did the CI run this against implementations?