increase test coverage of Promise.withResolvers #3936
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Oct 4, 2023
Comment on lines
32
to
36
| assert.sameValue( | ||
| Object.getOwnPropertyDescriptor(Promise.withResolvers, "prototype"), | ||
| undefined, | ||
| "Promise.withResolvers has no own prototype property" | ||
| ); |
There was a problem hiding this comment.
it'd be nice if this was in a separate file - my polyfills cover the first, but can't trivially cover the second, and i'd rather skip those tests.
Comment on lines
22
to
26
| assert.sameValue(Promise.withResolvers.length, 0); | ||
|
|
||
| verifyNotEnumerable(Promise.withResolvers, 'length'); | ||
| verifyNotWritable(Promise.withResolvers, 'length'); | ||
| verifyConfigurable(Promise.withResolvers, 'length'); |
There was a problem hiding this comment.
see #3935, let's use verifyProperty here
Comment on lines
23
to
27
| assert.sameValue(Promise.withResolvers.name, 'withResolvers'); | ||
|
|
||
| verifyNotEnumerable(Promise.withResolvers, 'name'); | ||
| verifyNotWritable(Promise.withResolvers, 'name'); | ||
| verifyConfigurable(Promise.withResolvers, 'name'); |
Comment on lines
17
to
19
| verifyNotEnumerable(Promise, 'withResolvers'); | ||
| verifyWritable(Promise, 'withResolvers'); | ||
| verifyConfigurable(Promise, 'withResolvers'); |
peetklecha
force-pushed
the
moar-promise-with-resolvers
branch
from
6292f9e
to
e5643e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.