Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporal: Update PlainMonthDay-related tests #3899

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Temporal: Update PlainMonthDay-related tests #3899

merged 5 commits into from
Oct 26, 2023

Commits on Oct 26, 2023

  1. Temporal: Update PlainMonthDay-related tests 

    As of tc39/proposal-temporal#2500 ,
year is always optional for the ISO 8601 calendar.
    @gibson042
    gibson042 committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    c42f75c View commit details
    Browse the repository at this point in the history

  2. Temporal: Move non-ISO calendar tests to intl402/ 

    We'll do this for now, then separately work on migrating all of the tests
that require a non-ISO8601 calendar but aren't dependent on it being any
particular calendar.
    @ptomato @gibson042
    ptomato authored and gibson042 committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    ca2c30e View commit details
    Browse the repository at this point in the history

  3. Temporal: Add more coverage for non-ISO PlainMonthDay underspecification 

    Built-in non-ISO calendars require either monthCode/day, or month/day plus
some form of year specification.

This adds test coverage for each of the categories listed in
tc39/proposal-temporal#2664, of which some must
currently reside in the test/intl402/ folders.
    @ptomato @gibson042
    ptomato authored and gibson042 committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    801997d View commit details
    Browse the repository at this point in the history

  4. Temporal: Fix test to check for TypeError with only one of era/eraYear 

    These tests were incorrect, in checking for a RangeError when only one of
the era/eraYear fields were given. From CalendarResolveFields:

"The operation throws a *TypeError* exception if the properties of
_fields_ are internally inconsistent within the calendar or insufficient
to identify a unique instance of _type_ in the calendar."
    @ptomato @gibson042
    ptomato authored and gibson042 committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    1dde925 View commit details
    Browse the repository at this point in the history

  5. Temporal: Use propertyBagObserver in monthDayFromFields test

    @ptomato @gibson042
    ptomato authored and gibson042 committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    49b08a8 View commit details
    Browse the repository at this point in the history