-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated Intl.DateTimeFormat.prototype.resolvedOptions() tests to reflect recent normative change #3885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-allen
force-pushed
the
pr-758
branch
3 times, most recently
from
July 27, 2023 01:04
3f447aa
to
15792da
Compare
Ms2ger
reviewed
Jul 27, 2023
test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle-default.js
Outdated
Show resolved
Hide resolved
ben-allen
force-pushed
the
pr-758
branch
2 times, most recently
from
July 27, 2023 12:52
ff6b21a
to
976299b
Compare
Ms2ger
requested changes
Aug 25, 2023
test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle-dateStyle.js
Outdated
Show resolved
Hide resolved
test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle-dateStyle.js
Outdated
Show resolved
Hide resolved
test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle-default.js
Outdated
Show resolved
Hide resolved
test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle-default.js
Outdated
Show resolved
Hide resolved
test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle-default.js
Outdated
Show resolved
Hide resolved
test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle-default.js
Outdated
Show resolved
Hide resolved
Ms2ger
added
the
awaiting consensus
This needs committee consensus before it can be eligible to be merged.
label
Aug 25, 2023
Ms2ger
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready when the spec is.
…hich now associates h12 with h23 rather than h24. see tc39/ecma402#758.
The normative change reached consensus in the TC39 meeting of 2023-09. Given Ms2ger's approval I think we can merge this. I squashed the updates from addressing code review comments into the original topical commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #3812
Fix #3876
tc39/ecma402#758 changes the
hourCycle
logic in Intl.DateTimeFormat.InitializeDateAndTime() to no longer erroneously assume thath24
is the 24 hour clock expected in locales usingh11
orh12
as defaults.7353744 and 15792da update hourCycle-default.js to reflect the new behaviour.
note: I don't believe any engine currently passes all of the tests in the new
hourCycle-default.js
. v8 and node fail because they associateh12
withh24
, as was required by the old algorithm, while jsc and spidermonkey fail because they ignore the -u-hc-h24 extension whenhour12
is set tofalse
, as below:commit 2648144 updates hourCycle-dateStyle.js with explanatory comments. Essentially, all this test does is verify that
hour12
andhourCycle
are set toundefined
whendateStyle
but nottimeStyle
is set, but the comments and metadata in the previous version appear to say something different.