Test Temporal.Instant w/ trailing zeroes in offset #3878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
approved these changes
Jul 25, 2023
I noticed a small test hole in codecov: we weren't testing Temporal.Instant parsing with trailing zeroes in the offset. I also didn't see fractional offset testing, so added that too.
justingrant
force-pushed
the
instant-trailing-zeroes
branch
from
a7946b8
to
a5da38b
Compare
|
I just rebased to main. No changes were needed. Can this PR be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a small test hole in codecov: we weren't testing
Temporal.Instantparsing with trailing zeroes in the offset. I also didn't see fractional offset testing, so added that too.