Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch test with old evaluation order for member assignment #3825

Closed
wants to merge 1 commit into from

Conversation

jedel1043
Copy link
Contributor

@jedel1043 jedel1043 commented May 5, 2023

Fixes #3407, see issue for context.
Should wait for a decision on tc39/ecma262#2659 before merging.

Mutually exclusive with #3824. This should only be merged if the new behaviour is considered a bug on the specification.

@jedel1043 jedel1043 requested a review from a team as a code owner May 5, 2023 16:00
@ptomato ptomato added the awaiting consensus This needs committee consensus before it can be eligible to be merged. label May 5, 2023
@jedel1043
Copy link
Contributor Author

Closing since #4052 was merged.

@jedel1043 jedel1043 closed this Apr 15, 2024
@jedel1043 jedel1043 deleted the assignment-not-reordering branch April 15, 2024 20:27
@ptomato
Copy link
Contributor

ptomato commented Apr 15, 2024

Sorry I did not notice before that these were the same! Thank you for your work even though it did not get merged in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting consensus This needs committee consensus before it can be eligible to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect tests after change to evaluation order for member assignment
2 participants