Update tests for PR "Read date-time options only once when creating DateTimeFormat objects" #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirmed with engine262 that this PR includes the correct updates for tc39/ecma402#709: engine262/engine262@3248ccc...gibson042:ecma402-gh-709-initializedatetimeformat But since test changes are required anyway, I'm proposing further improvements at tc39/ecma402#709 (comment) . Note also tc39/ecma402#747 , which suggests the possibility of future churn in this general area. |
ptomato
added
the
awaiting consensus
|
LGTM |
|
The consensus was reach in Day 1 of TC39 2023-07 meeting. |
Ms2ger
added
awaiting specification
and removed
awaiting consensus
|
The PR is landed into ECMA402 in tc39/ecma402@02bd03a (not part of PR709 due to a technical mistake while merging) |
…ateTimeFormat objects" Update tests for PR tc39/ecma402#709.
Ms2ger
force-pushed
the
date-time-options-new
branch
from
e5c02da
to
a0b06b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests for PR tc39/ecma402#709.