Remove no-longer supported private tag #2028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebkit/webkit.git at sha 801a7d15df on Fri Dec 21 2018 19:18:17 GMT+0000 (Coordinated Universal Time)
…revision sha's from export and changed files.
sourceRevisionAtLastExport: 801a7d15df targetRevisionAtLastExport: 8f629cd
…sha 89eb451c on Fri Dec 21 2018 19:21:03 GMT+0000 (Coordinated Universal Time)
…'s from export and changed files.
sourceRevisionAtLastExport: 89eb451c targetRevisionAtLastExport: 7519e1b
FrankYFTang
changed the title
|
based on discussion with @littledan I will change this PR to testing these same locale but with different expectation instead. Stay tune. |
Update same-line-async-gen-private-field-usage.js
…est262-automation-export-8f629cd87f Import test changes from JavaScriptCore
…ation-export-7519e1b462 Import test changes from V8
Move proposals that have been incorporated into the standard to the corresponding section.
Update rs-private-getter-alt.case
Add missing features to private elements tests
Previously, the early error prohibiting duplicate entries in UniqueFormalParameters was only tested in terms of async functions. In one case, this was misattributed to UniqeFormalParameters and only enforced for strict mode code. Extend coverage to the other function-creating productions which include UniqueFormalParameters (i.e. method definitions and non-async arrow functions), and update the existing tests to more accurately describe the source of the error.
This is due to the fact we now only accept Unicode Locale Identifier in UTS 35.
also add comments ref UTS35
…kYFTang/test262 into rmPrivateFromlikely-subtags
|
I totally messed up this PR. I will close it and open a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per tc39/proposal-intl-locale#66
private tags are no longer supported. Remove them from tests.