Improve tests for BigInt.prototype.valueOf #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leobalter
commented
Oct 3, 2017
| info: > | ||
| description: > | ||
| BigInt.prototype.valueOf returns the primitive BigInt value. | ||
| info: | | ||
| BigInt.prototype.valueOf ( ) | ||
|
|
||
| Return ? thisBigIntValue(this value). | ||
| includes: [typeCoercion.js] |
There was a problem hiding this comment.
I need to remove the includes... That's why the linter triggered an error
|
@spectranaut the commits d729577 and b307b80 should fix the remaining parts. |
rwaldron
reviewed
Oct 3, 2017
| var valueOf = BigInt.prototype.valueOf; | ||
|
|
||
| assert.sameValue(valueOf.call(0n), 0n, "0n"); | ||
| assert.sameValue(valueOf.call(Object(0n)), 0n, "Object(0n)"); |
rwaldron
reviewed
Oct 3, 2017
| var s = Symbol(); | ||
| assert.throws(TypeError, function() { | ||
| valueOf.call(s); | ||
| }, "symbol"); |
There was a problem hiding this comment.
Very clear, glad to see the helper going away where possible. Thanks for taking the extra time to refine these.
|
Note that although there were only valueOf tests checked in which used this infrastructure, there are more places in the spec where it would be applicable, namely in BigInt.prototype.toString and toLocaleString. cc @thejoshwolfe @cxielarko |
|
There is a PR for toString already which I'm working to apply fixes at this very moment. We should have an update soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.