-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor bugs in BigInt tests #1467
Comments
cc @cxielarko |
These changes LGTM! (the second test fails in spidermonkey too; the first passes but probably shouldn't) |
rwaldron
added a commit
to rwaldron/test262
that referenced
this issue
Mar 6, 2018
rwaldron
added a commit
to rwaldron/test262
that referenced
this issue
Mar 6, 2018
rwaldron
added a commit
to rwaldron/test262
that referenced
this issue
Mar 6, 2018
rwaldron
added a commit
to rwaldron/test262
that referenced
this issue
Mar 6, 2018
rwaldron
added a commit
to rwaldron/test262
that referenced
this issue
Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CC @rwaldron @leobalter @gsathya
I've found two minor issues with BigInt tests:
built-ins/BigInt/prototype/Symbol.toStringTag.js:
"verifyProperty" is destructive unless {restore: true} is passed. This makes the subsequent assert fail.
Fix:
built-ins/TypedArrays/ctors-bigint/typedarray-arg/typedarray-arg-other-ctor-returns-new-typedarray.js:
The inputs must have length 7 in order for the newly constructed arrays to have length 7 as well.
Fix:
The text was updated successfully, but these errors were encountered: