Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

param-dflt-yield-id-non-strict.js is onlyStrict #1175

Closed
mroch opened this issue Aug 13, 2017 · 1 comment
Closed

param-dflt-yield-id-non-strict.js is onlyStrict #1175

mroch opened this issue Aug 13, 2017 · 1 comment

Comments

@mroch
Copy link
Contributor

mroch commented Aug 13, 2017

test262/test/language/expressions/arrow-function/param-dflt-yield-id-non-strict.js

Line 14 in bcd308b

flags: [onlyStrict]

seems wrong for the non-strict file to have onlyStrict. I think it ends up testing the same thing as https://github.com/tc39/test262/blob/bcd308b553097a2662b594dd7178d521e8fc4aa6/test/language/expressions/arrow-function/param-dflt-yield-id-strict.js, and leaves the non-strict case uncovered.
rwaldron added a commit to rwaldron/test262 that referenced this issue Aug 14, 2017
@rwaldron
Remove incorrect early error machinery. Fixes tc39gh-1175
07b50a7
@rwaldron
Copy link
Contributor

Your intuition is correct, thanks for filing this. I've opened a PR with relevant corrections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mroch @rwaldron