Skip to content

Commit

Permalink
Add tests for DurationFormat PR 172 and 167
Browse files Browse the repository at this point in the history
Test the order of resolvedOptions in default setting
Also add test to check the reading order of options based on the
property returned in the default setting resolvedOptions.

tc39/proposal-intl-duration-format#167
tc39/proposal-intl-duration-format#172
https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.prototype.resolvedOptions

These two PRs are presenting to TC39 2023-09 meeting

Swap actual/expected order

Update test/intl402/DurationFormat/constructor-option-read-order.js

Co-authored-by: André Bargull <[email protected]>

Fix per anba suggestion
  • Loading branch information
FrankYFTang authored and ptomato committed Jul 24, 2024
1 parent 79df6ec commit 6b8006d
Show file tree
Hide file tree
Showing 2 changed files with 81 additions and 0 deletions.
47 changes: 47 additions & 0 deletions test/intl402/DurationFormat/constructor-option-read-order.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-Intl.DurationFormat
description: Checks the order of option read.
features: [Intl.DurationFormat]
includes: [compareArray.js]
---*/

let optionKeys = Object.keys((new Intl.DurationFormat()).resolvedOptions());
let opt = {};
let readKeys = new Array();
// For each item returned by resolvedOptions of default, add a getter
// to track the reading order.
optionKeys.forEach((property) =>
Object.defineProperty(opt, property, {
get() {
readKeys[readKeys.length] = property;
return undefined;
},
}));
let p = new Intl.DurationFormat(undefined, opt);
assert.compareArray(
readKeys,
['numberingSystem',
'style',
'years',
'yearsDisplay',
'months',
'monthsDisplay',
'weeks',
'weeksDisplay',
'days',
'daysDisplay',
'hours',
'hoursDisplay',
'minutes',
'minutesDisplay',
'seconds',
'secondsDisplay',
'milliseconds',
'millisecondsDisplay',
'microseconds',
'microsecondsDisplay',
'nanoseconds',
'nanosecondsDisplay']);
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-intl.durationformat.prototype.resolvedoptions
description: order of property keys for the object returned by resolvedOptions()
features: [Intl.DurationFormat]
includes: [compareArray.js]
---*/

assert.compareArray(
Object.keys((new Intl.DurationFormat()).resolvedOptions()),
['locale',
'numberingSystem',
'style',
'years',
'yearsDisplay',
'months',
'monthsDisplay',
'weeks',
'weeksDisplay',
'days',
'daysDisplay',
'hours',
'hoursDisplay',
'minutes',
'minutesDisplay',
'seconds',
'secondsDisplay',
'milliseconds',
'millisecondsDisplay',
'microseconds',
'microsecondsDisplay',
'nanoseconds',
'nanosecondsDisplay']);

0 comments on commit 6b8006d

Please sign in to comment.