Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an “author” column to each table #95

Merged
merged 3 commits into from
Dec 4, 2017
Merged

Add an “author” column to each table #95

merged 3 commits into from
Dec 4, 2017

Conversation

mathiasbynens
Copy link
Member

Closes #93.

@mathiasbynens
Copy link
Member Author

ProTip™: prettier can auto-format these tables. prettier README.md

@mathiasbynens mathiasbynens requested a review from ljharb December 4, 2017 04:26
ljharb
ljharb approved these changes Dec 4, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - can we make the same change to the finished proposals list?

(also, the ecma402/ lists?)

@mathiasbynens
Copy link
Member Author

Added the column to the finished proposals list as well.

@mathiasbynens
Copy link
Member Author

And to the Intl tables! Let’s get this merged.

@ljharb
Copy link
Member

ljharb commented Dec 4, 2017

Thanks! I'll do the rebase, and we'll get this in.

@ljharb ljharb merged commit 8aea1fb into master Dec 4, 2017
@ljharb ljharb deleted the author branch December 4, 2017 06:57
@littledan
Copy link
Member

Thanks for this improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathiasbynens @ljharb @littledan