Rounding, Part 2 #907
Merged
Rounding, Part 2 #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
requested review from
Ms2ger,
justingrant,
pipobscure,
jasonwilliams,
sffc,
gibson042 and
ryzokuken
Codecov Report
@@ Coverage Diff @@
## main #907 +/- ##
==========================================
+ Coverage 93.18% 93.54% +0.35%
==========================================
Files 17 17
Lines 5373 5671 +298
Branches 826 856 +30
==========================================
+ Hits 5007 5305 +298
Misses 359 359
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
justingrant
reviewed
Sep 15, 2020
ptomato
force-pushed
the
827-difference-rounding
branch
2 times, most recently
from
929ab41
to
8814097
Compare
Ms2ger
approved these changes
Sep 16, 2020
| const largestUnit = ES.ToLargestTemporalUnit(options, 'seconds', ['years', 'months', 'weeks', 'days']); | ||
| const disallowedUnits = ['years', 'months', 'weeks', 'days']; | ||
| const smallestUnit = ES.ToSmallestTemporalDurationUnit(options, 'nanoseconds', disallowedUnits); | ||
| let defaultLargestUnit = 'seconds'; |
There was a problem hiding this comment.
Suggested change
| let defaultLargestUnit = 'seconds'; | |
| const defaultLargestUnit = 'seconds'; |
There was a problem hiding this comment.
It's reassigned in the next line if smallestUnit is larger than defaultLargestUnit.
ptomato
force-pushed
the
827-difference-rounding
branch
from
8814097
to
abf2474
Compare
Includes several new abstract operations: - ToSmallestTemporalDurationUnit, which is distinct from ToSmallestTemporalUnit because it prefers plural unit names and does have a fallback value; - ValidateTemporalDifferenceUnits, which makes sure that largestUnit is not smaller than smallestUnit; - and MaximumTemporalDurationRoundingIncrement, which computes the maximum (not inclusive) value for roundingIncrement given the value of smallestUnit, for rounding a Temporal.Duration. All of these will be reused for Temporal.DateTime.difference and Temporal.Time.difference in subsequent commits. See: #827
Includes a new abstract operation RoundDuration, which will be used in the other types' difference() methods and Temporal.Duration.round as well. See: #827
ptomato
force-pushed
the
827-difference-rounding
branch
from
abf2474
to
181793d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds rounding options to Temporal.Absolute.prototype.difference, Temporal.DateTime.prototype.difference, and Temporal.Time.prototype.difference.
See: #827.