Update from() methods. #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #502 +/- ##
==========================================
+ Coverage 96.83% 97.56% +0.72%
==========================================
Files 17 17
Lines 3953 3986 +33
Branches 582 583 +1
==========================================
+ Hits 3828 3889 +61
+ Misses 123 95 -28
Partials 2 2
Continue to review full report at Codecov.
|
ptomato
approved these changes
Apr 8, 2020
Co-authored-by: Philip Chimento <[email protected]>
…bjects. Co-authored-by: Philip Chimento <[email protected]>
Co-authored-by: Philip Chimento <[email protected]>
Co-authored-by: Philip Chimento <[email protected]>
Co-authored-by: Philip Chimento <[email protected]>
Co-authored-by: Philip Chimento <[email protected]>
Co-authored-by: Philip Chimento <[email protected]>
Co-authored-by: Philip Chimento <[email protected]>
Co-authored-by: Philip Chimento <[email protected]>
Co-authored-by: Philip Chimento <[email protected]>
Co-authored-by: Philip Chimento <[email protected]>
Co-authored-by: Philip Chimento <[email protected]>
Co-authored-by: Philip Chimento <[email protected]>
Each type's from() method (excluding Absolute and TimeZone, which cannot take property bags) now calls a new abstract operation, ToFooRecord, which takes a property bag or an object of the actual type, and returns a Record with the appropriate slots. If the argument isn't an object, then from() calls ParseFooString directly. We delete the FooFromString and ToFoo operations. In either case, from() will then apply the disambiguation (if applicable) and create the Temporal object. Co-authored-by: Philip Chimento <[email protected]>
Co-authored-by: Philip Chimento <[email protected]>
Ms2ger
force-pushed
the
232-from-cloning
branch
from
71d1898 to
6703c26
Compare
ryzokuken
approved these changes
Apr 23, 2020
Co-authored-by: Philip Chimento <[email protected]>
Ms2ger
force-pushed
the
232-from-cloning
branch
from
4116676 to
d0d9567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.