Skip to content

Conversation

@gibson042
Copy link
Member

@gibson042 gibson042 commented Sep 19, 2025

Fixes #3153

Note that checking against test262 will require locally adopting js-temporal/temporal-test262-runner#20, manually creating the missing directory, or a similar action.

@gibson042 gibson042 requested a review from ptomato September 19, 2025 19:20
@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.82%. Comparing base (6274e5d) to head (6798571).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
polyfill/lib/calendar.mjs 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3154      +/-   ##
==========================================
- Coverage   96.86%   96.82%   -0.04%     
==========================================
  Files          22       22              
  Lines       10080    10084       +4     
  Branches     1824     1825       +1     
==========================================
  Hits         9764     9764              
- Misses        267      270       +3     
- Partials       49       50       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I had started looking for speedups at a lower level but this sidesteps the whole problem (for calendars with 12-month years, at least.)

@ptomato ptomato merged commit ad9c6ff into tc39:main Sep 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reference implementation has pathologically slow date difference case

2 participants